Forked Pipeline SA Password Test by paulmedynski · Pull Request #3952 · dotnet/SqlClient

paulmedynski · 2026-02-11T17:40:10Z

This PR changes how forked repos acquire the SA password used to configure local SQL Server instances. It tests the pipeline runs from a forked repo, and will be merged to a normal dev branch before being properly reviewed and merged to main.

Added a note about testing fork PR pipeline runs.

Added a comment to trigger PR pipelines.

Copilot

Pull request overview

This PR is a dummy change intended to validate how CI behaves for pull requests opened from forks.

Changes:

Adds a placeholder line to README.md to create a diff and trigger fork PR pipeline execution.

README.md

This reverts commit 2888148.

This reverts commit 179f858.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

- Plumbed saPassword down through all of the stages, jobs, and steps that need it. - No more global $(Password) variable.

…at use time.

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 9 comments.

eng/pipelines/stages/generate-secrets-ci-stage.yml

eng/pipelines/common/templates/steps/update-config-file-step.yml

eng/pipelines/dotnet-sqlclient-ci-core.yml

eng/pipelines/common/templates/steps/configure-sql-server-win-step.yml

eng/pipelines/common/templates/steps/configure-sql-server-linux-step.yml

eng/pipelines/common/templates/steps/configure-sql-server-macos-step.yml

- Moved secrets_stage dependency into stages.

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.

eng/pipelines/stages/build-azure-package-ci-stage.yml

eng/pipelines/common/templates/stages/ci-run-tests-stage.yml

eng/pipelines/common/templates/steps/configure-sql-server-macos-step.yml

eng/pipelines/sqlclient-pr-project-ref-pipeline.yml

eng/pipelines/stages/generate-secrets-ci-stage.yml

eng/pipelines/stages/stress-tests-ci-stage.yml

eng/pipelines/stages/generate-secrets-ci-stage.yml

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

eng/pipelines/sqlclient-pr-project-ref-pipeline.yml

…ebug parameters.

codecov · 2026-02-12T04:35:03Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.98%. Comparing base (06b5810) to head (f428d91).
⚠️ Report is 1 commits behind head on dev/paul/db-password.

Additional details and impacted files

@@                   Coverage Diff                    @@
##           dev/paul/db-password    #3952      +/-   ##
========================================================
- Coverage                 67.23%   66.98%   -0.26%     
========================================================
  Files                       260      260              
  Lines                     65704    65704              
========================================================
- Hits                      44176    44010     -166     
- Misses                    21528    21694     +166

Flag	Coverage Δ
netcore	`67.27% <ø> (-0.29%)`	⬇️
netfx	`65.83% <ø> (-0.23%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

eng/pipelines/stages/build-azure-package-ci-stage.yml:233

This call passes sqlRootPath, but configure-sql-server-win-step.yml defines the parameter as SQLRootPath. As written, the template will fall back to the default (empty) and skip SQLRootPath-dependent setup (e.g., FileStream). Rename the argument key to match the template parameter.

                # These variables are from an Azure DevOps Library variable
                # group.
                fileStreamDirectory: $(FileStreamDirectory)
                sqlRootPath: $(SQL22RootPath)
          # The ADO-MMS22-SQL22 image includes a local SQL Server that supports

Copilot · 2026-02-12T10:41:13Z

eng/pipelines/common/templates/steps/configure-sql-server-macos-step.yml

+      # Configure the prompt to show the current timestamp so we can see how long each command takes.
+      export PS4='+ [$(date "+%Y-%m-%d %H:%M:%S")] '
+      set -x

-    # Password for the SA user (required)
-    MSSQL_SA_PW="$(Password)"
+      # Install Docker and SQLCMD tools.
+      brew install colima
+      brew install --cask docker
+      brew tap microsoft/mssql-release https://github.com/Microsoft/homebrew-mssql-release
+      brew update
+      HOMEBREW_ACCEPT_EULA=Y brew install mssql-tools18
+      colima start --arch x86_64
+      docker --version
+      docker pull mcr.microsoft.com/mssql/server:2022-latest

-    docker run -e "ACCEPT_EULA=Y" -e "MSSQL_SA_PASSWORD=$MSSQL_SA_PW" -p 1433:1433 -p 1434:1434 --name sql1 --hostname sql1 -d mcr.microsoft.com/mssql/server:2022-latest
+      # Password for the SA user (required)
+      MSSQL_SA_PW="${{ parameters.saPassword }}"

-    sleep 5
+      docker run -e "ACCEPT_EULA=Y" -e "MSSQL_SA_PASSWORD=$MSSQL_SA_PW" -p 1433:1433 -p 1434:1434 --name sql1 --hostname sql1 -d mcr.microsoft.com/mssql/server:2022-latest



This script enables set -x before running commands that include the SA password (e.g., docker run ... MSSQL_SA_PASSWORD=... and sqlcmd -P ...), which will echo the expanded password into logs. Disable xtrace around password-bearing commands and/or source the password from a masked secret variable.

Copilot · 2026-02-12T10:41:13Z

eng/pipelines/common/templates/steps/configure-sql-server-win-step.yml

+        SQL_USER: ${{parameters.user }}
+        SQL_PASSWD: ${{ parameters.saPassword }}
+
+  - ${{ if ne(parameters.FileStreamDirectory, '') }}:


The FileStream directory block checks parameters.FileStreamDirectory, but this template defines fileStreamDirectory (lowercase f). This will either fail template expansion (unknown parameter) or skip the step unexpectedly. Update the condition to use the correct parameter name.

Suggested change

- ${{ if ne(parameters.FileStreamDirectory, '') }}:

- ${{ if ne(parameters.fileStreamDirectory, '') }}:

Copilot · 2026-02-12T10:41:13Z

eng/pipelines/sqlclient-pr-project-ref-pipeline.yml

+    # TODO: Temporaryily forcing debug for forked repo pipeline runs.
+    # debug: ${{ parameters.debug }}
+    debug: true


debug is hard-coded to true, which ignores the pipeline parameter and will force extra debug steps/logging on all PR runs. If this is only for temporary fork testing, gate it behind a parameter/condition (e.g., only when System.PullRequest.IsFork is true) or revert before merging.

Suggested change

# TODO: Temporaryily forcing debug for forked repo pipeline runs.

# debug: ${{ parameters.debug }}

debug: true

debug: ${{ parameters.debug }}

Update README with fork PR pipeline note

179f858

Added a note about testing fork PR pipeline runs.

Copilot AI review requested due to automatic review settings February 11, 2026 17:40

Copilot started reviewing on behalf of paulmedynski February 11, 2026 17:40 View session

Add no-op edit to build.proj

2888148

Added a comment to trigger PR pipelines.

Copilot AI reviewed Feb 11, 2026

View reviewed changes

README.md Outdated Show resolved Hide resolved

paulmedynski mentioned this pull request Feb 11, 2026

Fix forked repo local SQL Server passwords #3950

Open

paulmedynski added 4 commits February 11, 2026 14:11

Revert "Add no-op edit to build.proj"

5f0f6b1

This reverts commit 2888148.

Revert "Update README with fork PR pipeline note"

c48bc70

This reverts commit 179f858.

Fixed typo comparing System.PullRequest.IsFork value.

121b4bb

Removed IsFork check, and now generating a password all the time.

59fdfea

Copilot AI review requested due to automatic review settings February 11, 2026 18:46

Copilot started reviewing on behalf of paulmedynski February 11, 2026 18:46 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

paulmedynski added 2 commits February 11, 2026 16:13

- Now generating secrets for the entire pipeline.

c54fbf3

- Plumbed saPassword down through all of the stages, jobs, and steps that need it. - No more global $(Password) variable.

Added debugging to see the generated secrets at generation time, and …

d4d4ec9

…at use time.

Copilot AI review requested due to automatic review settings February 11, 2026 20:53

Copilot started reviewing on behalf of paulmedynski February 11, 2026 20:53 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

paulmedynski added 2 commits February 11, 2026 17:01

Forcing debug for forked repo pipeline runs.

538bbe3

- Hopefully fixed expansion of stage dependencies.

478ba6c

- Moved secrets_stage dependency into stages.

Copilot AI review requested due to automatic review settings February 11, 2026 22:55

Copilot started reviewing on behalf of paulmedynski February 11, 2026 22:55 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

paulmedynski added 2 commits February 11, 2026 20:58

Addressed Copilot comments, and fixed some runtime bugs.

20d7103

Fixed debug DLL output and Windows WMI call.

ad54383

Copilot AI review requested due to automatic review settings February 12, 2026 02:15

Copilot started reviewing on behalf of paulmedynski February 12, 2026 02:15 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

eng/pipelines/sqlclient-pr-project-ref-pipeline.yml Show resolved Hide resolved

Fixed Windows-specific powershell commands, and removed unnecessary d…

f428d91

…ebug parameters.

paulmedynski marked this pull request as ready for review February 12, 2026 10:34

paulmedynski requested a review from a team as a code owner February 12, 2026 10:34

Copilot AI review requested due to automatic review settings February 12, 2026 10:34

Copilot started reviewing on behalf of paulmedynski February 12, 2026 10:35 View session

paulmedynski changed the title ~~[DO NOT MERGE] Forked Pipeline Test~~ Forked Pipeline SA Password Test Feb 12, 2026

paulmedynski merged commit a567b28 into dotnet:dev/paul/db-password Feb 12, 2026
155 of 298 checks passed

paulmedynski deleted the dev/paul/db-password branch February 12, 2026 10:37

Copilot AI reviewed Feb 12, 2026

View reviewed changes

paulmedynski added a commit that referenced this pull request Feb 12, 2026

Forked Pipeline SA Password Test (#3952)

0948c0b

	- ${{ if ne(parameters.FileStreamDirectory, '') }}:
	- ${{ if ne(parameters.fileStreamDirectory, '') }}:

Conversation

paulmedynski commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

codecov bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

paulmedynski commented Feb 11, 2026 •

edited

Loading

codecov bot commented Feb 12, 2026 •

edited

Loading